diff --git a/.github/multi-node-filebeat-check.sh b/.github/multi-node-filebeat-check.sh index 39a21827..3052f69e 100755 --- a/.github/multi-node-filebeat-check.sh +++ b/.github/multi-node-filebeat-check.sh @@ -1,18 +1,39 @@ -filebeatout1=$(docker exec multi-node_wazuh.master_1 sh -c 'filebeat test output') -filebeatstatus1=$(echo "${filebeatout1}" | grep -c OK) -if [[ filebeatstatus1 -eq 7 ]]; then - echo "No errors in master filebeat" +COMMAND_TO_EXECUTE="filebeat test output" + +MASTER_CONTAINERS=$(docker ps --format '{{.Names}}' | grep -E 'master') + +if [ -z "$MASTER_CONTAINERS" ]; then + echo "No containers were found with 'master' in their name." else - echo "Errors in master filebeat" - echo "${filebeatout1}" - exit 1 + for MASTER_CONTAINERS in $MASTER_CONTAINERS; do + FILEBEAT_OUTPUT=$(docker exec "$MASTER_CONTAINERS" $COMMAND_TO_EXECUTE) + FILEBEAT_STATUS=$(echo "${FILEBEAT_OUTPUT}" | grep -c OK) + if [[ $FILEBEAT_STATUS -eq 7 ]]; then + echo "No errors in filebeat" + echo "${FILEBEAT_OUTPUT}" + else + echo "Errors in filebeat" + echo "${FILEBEAT_OUTPUT}" + exit 1 + fi + done fi -filebeatout2=$(docker exec multi-node_wazuh.worker_1 sh -c 'filebeat test output') -filebeatstatus2=$(echo "${filebeatout2}" | grep -c OK) -if [[ filebeatstatus2 -eq 7 ]]; then - echo "No errors in worker filebeat" + +MASTER_CONTAINERS=$(docker ps --format '{{.Names}}' | grep -E 'worker') + +if [ -z "$MASTER_CONTAINERS" ]; then + echo "No containers were found with 'worker' in their name." else - echo "Errors in worker filebeat" - echo "${filebeatout2}" - exit 1 + for MASTER_CONTAINERS in $MASTER_CONTAINERS; do + FILEBEAT_OUTPUT=$(docker exec "$MASTER_CONTAINERS" $COMMAND_TO_EXECUTE) + FILEBEAT_STATUS=$(echo "${FILEBEAT_OUTPUT}" | grep -c OK) + if [[ $FILEBEAT_STATUS -eq 7 ]]; then + echo "No errors in filebeat" + echo "${FILEBEAT_OUTPUT}" + else + echo "Errors in filebeat" + echo "${FILEBEAT_OUTPUT}" + exit 1 + fi + done fi \ No newline at end of file diff --git a/.github/single-node-filebeat-check.sh b/.github/single-node-filebeat-check.sh index 7f9ae7d3..1979d25b 100755 --- a/.github/single-node-filebeat-check.sh +++ b/.github/single-node-filebeat-check.sh @@ -1,9 +1,20 @@ -filebeatout=$(docker exec single-node_wazuh.manager_1 sh -c 'filebeat test output') -filebeatstatus=$(echo "${filebeatout}" | grep -c OK) -if [[ filebeatstatus -eq 7 ]]; then - echo "No errors in filebeat" +COMMAND_TO_EXECUTE="filebeat test output" + +MASTER_CONTAINERS=$(docker ps --format '{{.Names}}' | grep -E 'manager') + +if [ -z "$MASTER_CONTAINERS" ]; then + echo "No containers were found with 'manager' in their name." else - echo "Errors in filebeat" - echo "${filebeatout}" - exit 1 + for MASTER_CONTAINERS in $MASTER_CONTAINERS; do + FILEBEAT_OUTPUT=$(docker exec "$MASTER_CONTAINERS" $COMMAND_TO_EXECUTE) + FILEBEAT_STATUS=$(echo "${FILEBEAT_OUTPUT}" | grep -c OK) + if [[ $FILEBEAT_STATUS -eq 7 ]]; then + echo "No errors in filebeat" + echo "${FILEBEAT_OUTPUT}" + else + echo "Errors in filebeat" + echo "${FILEBEAT_OUTPUT}" + exit 1 + fi + done fi \ No newline at end of file diff --git a/.github/workflows/Procedure_push_docker_images.yml b/.github/workflows/Procedure_push_docker_images.yml index f9650f84..bdb7a015 100644 --- a/.github/workflows/Procedure_push_docker_images.yml +++ b/.github/workflows/Procedure_push_docker_images.yml @@ -116,12 +116,6 @@ jobs: username: ${{ secrets.DOCKERHUB_USERNAME }} password: ${{ secrets.DOCKERHUB_PASSWORD }} - - name: Install Docker Compose - run: | - sudo apt-get update - sudo apt-get install -y docker-compose - echo "Installed Docker Compose version: $(docker-compose --version)" - - name: Build Wazuh images run: | IMAGE_TAG=${{ inputs.image_tag }} diff --git a/.github/workflows/push.yml b/.github/workflows/push.yml index 8e508384..0d036999 100644 --- a/.github/workflows/push.yml +++ b/.github/workflows/push.yml @@ -10,11 +10,6 @@ jobs: - name: Check out code uses: actions/checkout@v4 - - name: Install docker-compose - run: | - curl -L "https://github.com/docker/compose/releases/download/1.29.2/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose - chmod +x /usr/local/bin/docker-compose - - name: Build Wazuh images run: build-docker-images/build-images.sh @@ -76,11 +71,6 @@ jobs: - name: Check out code uses: actions/checkout@v4 - - name: Install docker-compose - run: | - curl -L "https://github.com/docker/compose/releases/download/1.29.2/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose - chmod +x /usr/local/bin/docker-compose - - name: Create enviroment variables run: cat .env > $GITHUB_ENV @@ -112,10 +102,10 @@ jobs: docker load --input ./wazuh-agent.tar - name: Create single node certficates - run: docker-compose -f single-node/generate-indexer-certs.yml run --rm generator + run: docker compose -f single-node/generate-indexer-certs.yml run --rm generator - name: Start single node stack - run: docker-compose -f single-node/docker-compose.yml up -d + run: docker compose -f single-node/docker-compose.yml up -d - name: Check Wazuh indexer start run: | @@ -222,11 +212,6 @@ jobs: - name: Check out code uses: actions/checkout@v4 - - name: Install docker-compose - run: | - curl -L "https://github.com/docker/compose/releases/download/1.29.2/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose - chmod +x /usr/local/bin/docker-compose - - name: Create enviroment variables run: cat .env > $GITHUB_ENV @@ -262,10 +247,10 @@ jobs: rm -rf wazuh-manager.tar wazuh-indexer.tar wazuh-dashboard.tar wazuh-agent.tar - name: Create multi node certficates - run: docker-compose -f multi-node/generate-indexer-certs.yml run --rm generator + run: docker compose -f multi-node/generate-indexer-certs.yml run --rm generator - name: Start multi node stack - run: docker-compose -f multi-node/docker-compose.yml up -d + run: docker compose -f multi-node/docker-compose.yml up -d - name: Check Wazuh indexer start run: | diff --git a/CHANGELOG.md b/CHANGELOG.md index 9c61ed54..e8316444 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ All notable changes to this project will be documented in this file. ### Added +- Fix Warning message when migrating Docker compose v2 ([#1828](https://github.com/wazuh/wazuh-docker/pull/1828)) - Add wazuh agent test and push ([#1817](https://github.com/wazuh/wazuh-docker/pull/1817)) - Add Wazuh agent image build and deploy ([#1816](https://github.com/wazuh/wazuh-docker/pull/1816)) diff --git a/build-docker-images/build-images.sh b/build-docker-images/build-images.sh index fb16dc4f..fbe65829 100755 --- a/build-docker-images/build-images.sh +++ b/build-docker-images/build-images.sh @@ -65,7 +65,7 @@ build() { echo WAZUH_FILEBEAT_MODULE=$WAZUH_FILEBEAT_MODULE >> .env echo WAZUH_UI_REVISION=$WAZUH_UI_REVISION >> .env - docker-compose -f build-docker-images/build-images.yml --env-file .env build --no-cache || clean 1 + docker compose -f build-docker-images/build-images.yml --env-file .env build --no-cache || clean 1 return 0 } diff --git a/build-docker-images/build-images.yml b/build-docker-images/build-images.yml index afa31d98..ed784cec 100644 --- a/build-docker-images/build-images.yml +++ b/build-docker-images/build-images.yml @@ -1,6 +1,4 @@ # Wazuh App Copyright (C) 2017, Wazuh Inc. (License GPLv2) -version: '3.7' - services: wazuh.manager: build: diff --git a/indexer-certs-creator/README.md b/indexer-certs-creator/README.md index b7dbc565..10965097 100644 --- a/indexer-certs-creator/README.md +++ b/indexer-certs-creator/README.md @@ -5,5 +5,5 @@ The dockerfile hosted in this directory is used to build the image used to boot To create the image, the following command must be executed: ``` -$ docker build -t wazuh/wazuh-certs-generator:0.0.1 . +$ docker build -t wazuh/wazuh-certs-generator:0.0.2 . ``` diff --git a/multi-node/README.md b/multi-node/README.md index c1e8b998..678fa782 100644 --- a/multi-node/README.md +++ b/multi-node/README.md @@ -1,6 +1,6 @@ # Deploy Wazuh Docker in multi node configuration -This deployment is defined in the `docker-compose.yml` file with two Wazuh manager containers, three Wazuh indexer containers, and one Wazuh dashboard container. It can be deployed by following these steps: +This deployment is defined in the `docker-compose.yml` file with two Wazuh manager containers, three Wazuh indexer containers, and one Wazuh dashboard container. It can be deployed by following these steps: 1) Increase max_map_count on your host (Linux). This command must be run with root permissions: ``` @@ -8,18 +8,18 @@ $ sysctl -w vm.max_map_count=262144 ``` 2) Run the certificate creation script: ``` -$ docker-compose -f generate-indexer-certs.yml run --rm generator +$ docker compose -f generate-indexer-certs.yml run --rm generator ``` -3) Start the environment with docker-compose: +3) Start the environment with docker compose: - In the foregroud: ``` -$ docker-compose up +$ docker compose up ``` - In the background: ``` -$ docker-compose up -d +$ docker compose up -d ``` diff --git a/multi-node/docker-compose.yml b/multi-node/docker-compose.yml index dd9d0c53..637c7cb7 100644 --- a/multi-node/docker-compose.yml +++ b/multi-node/docker-compose.yml @@ -1,6 +1,4 @@ # Wazuh App Copyright (C) 2017, Wazuh Inc. (License GPLv2) -version: '3.7' - services: wazuh.master: image: wazuh/wazuh-manager:4.12.2 diff --git a/multi-node/generate-indexer-certs.yml b/multi-node/generate-indexer-certs.yml index dbf2b079..3142ab1a 100644 --- a/multi-node/generate-indexer-certs.yml +++ b/multi-node/generate-indexer-certs.yml @@ -1,6 +1,4 @@ # Wazuh App Copyright (C) 2017, Wazuh Inc. (License GPLv2) -version: '3' - services: generator: image: wazuh/wazuh-certs-generator:0.0.2 diff --git a/single-node/README.md b/single-node/README.md index efd303c7..1a93b6c9 100644 --- a/single-node/README.md +++ b/single-node/README.md @@ -8,17 +8,17 @@ $ sysctl -w vm.max_map_count=262144 ``` 2) Run the certificate creation script: ``` -$ docker-compose -f generate-indexer-certs.yml run --rm generator +$ docker compose -f generate-indexer-certs.yml run --rm generator ``` -3) Start the environment with docker-compose: +3) Start the environment with docker compose: - In the foregroud: ``` -$ docker-compose up +$ docker compose up ``` - In the background: ``` -$ docker-compose up -d +$ docker compose up -d ``` The environment takes about 1 minute to get up (depending on your Docker host) for the first time since Wazuh Indexer must be started for the first time and the indexes and index patterns must be generated. diff --git a/single-node/docker-compose.yml b/single-node/docker-compose.yml index 207fc9fb..1f3910d5 100644 --- a/single-node/docker-compose.yml +++ b/single-node/docker-compose.yml @@ -1,6 +1,4 @@ # Wazuh App Copyright (C) 2017, Wazuh Inc. (License GPLv2) -version: '3.7' - services: wazuh.manager: image: wazuh/wazuh-manager:4.12.2 diff --git a/single-node/generate-indexer-certs.yml b/single-node/generate-indexer-certs.yml index 3e0eb6fd..b7b7efb6 100644 --- a/single-node/generate-indexer-certs.yml +++ b/single-node/generate-indexer-certs.yml @@ -1,6 +1,4 @@ # Wazuh App Copyright (C) 2017, Wazuh Inc. (License GPLv2) -version: '3' - services: generator: image: wazuh/wazuh-certs-generator:0.0.2